[Panel-devel] Tooltips for Plasma::Widget's

[Jason Stubbs]

On Friday 21 December 2007 00:27:02 Dan Meltzer wrote:
> On 12/20/07, Jason Stubbs <jasonbstubbs at gmail.com> wrote:
> > One last thing (which might be a code convention that I don't know about)
> > but why the e->accept()s? It doesn't do anything in hover events and
> > always defaults to accept() in methods where it is relevant.
> >
> > Likewise with calling QGraphicsItem::hoverEvent() as it doesn't do
> > anything except possibly call update(). The documentation is unclear on
> > whether it even does that much - in my experience, it doesn't.
>
> I did it primarily to be safe.. in case the trolls decide in the
> future that qgi::hoverEvent is important we don't lose anything.. I
> don't think it adds problems to have?

Personally, I find it to be a small obfuscation. Rather than focusing on the 
code that does stuff, I start thinking about whether those bits were put 
there with the intention of them actually doing something. But like I said, 
I'm not sure what the convention is...

-- 
Jason Stubbs