[Panel-devel] Multiple batteries support in battery applet

Sebastian Kuegler sebas at kde.org
Wed Dec 19 15:25:28 CET 2007


Hi Maor,

On Wednesday 19 December 2007 06:18:39 maor wrote:
> I'm new here ,well no actually new on the list just on the active way :-)
> Having some free time  ,I've been trying to update the power management
> engine and battery applet to support deices with multiple batteries. I've
> attached the resulted patches. It's seems to work fine beside the tooltip
> the i still haven't decided how it should be done. I'll appreciate your
> feedback.

Rocking!

Can you quickly explain what the patch does? I assume (from a glance at the 
code) that it shows two batteries?

The reason I'm asking is because I recall someone having issues with two bays 
and one battery. If the first bay found doesn't contain a battery, the applet 
assumes there is none, but the second bay isn't checked. It would be nice if 
your patch covered that as well.

I don't see any problems with the patch, and I'm inclined to commit it 
otherwise.

Thanks,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071219/a98a3cf9/attachment.pgp 


More information about the Panel-devel mailing list