[Panel-devel] [PATCH] Plasma::icon resizing

[Aaron J. Seigo]

On Tuesday 18 December 2007, Jason Stubbs wrote:
> On Tuesday 18 December 2007 03:48:42 Marco Martin wrote:
> > Hi,
> > this patch makes the icons to resize when the applet is resized, and
> > sized small enough to leave room for the text label.
> > how does it look?
>
> Wow! Less code than I thought it would take.
>
> I tested by adding labels on to the icons for the lock/logout widget.
> You'll need to remove expandingDirections() so that the icon will expand
> when in a layout too. Also, there doesn't seem to be quite enough room for
> the text as well. But it's close. :)

and then you can commit; good work to everyone working on the icon issues =)

btw.. it pains me to be so anal about this because the content is good and i 
hate to keep harping on style as if matters more than the content .. but.. 
yeah..

+    }else{
+        iconWidth = size().height()
+         - d->verticalMargin[Private::IconMargin].top
+         - d->verticalMargin[Private::IconMargin].bottom;
+    }

should be

+    } else {
+        iconWidth = size().height() -
+                    d->verticalMargin[Private::IconMargin].top -
+                    d->verticalMargin[Private::IconMargin].bottom;
+    }

(he says, hoping people don't get tired of the "i'd really like a 
semi-consistent code base" bit ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071218/ded4d2fd/attachment.pgp