[Panel-devel] [Bug 153872] Compic Strip Plasmoid does not load XKCD comic

[Aaron J.Seigo]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153872         




------- Additional Comments From aseigo kde org  2007-12-12 09:09 -------
On Wednesday 12 December 2007, Markus Mauder wrote:
> > in any case, i can confirm that the xkcd loader does indeed work as long
> > as there is a comic available for that day.
>
> Are you sure?


yeah, i worded that hastily. the problem is that there aren't daily strips and 
the code doesn't take that into consideration. it's a flawed assumption, 
though one that follows the other comic strip fetchers. as you note:

> Looking at the code here the data engine just tries to 
> get an id of however many days elapsed since 2006-12-06 (~ 371 days
> today?) while the number is currently at 356. As there are no daily
> updates this approach cannot really work.


yes ...

> > it would probably make sense to show a "no comic available today" message
> > in that case, or even if possible just show the latest one.
>
> I sent Tobias a patch a while back which retrieves the currently
> newest number and calculates earlier ids relative from there. This


sounds sane.

> - it doesn't really correlate the date to the strip. There is no
> information about the publishing date on the site, except in the rss
> feed. I tried using that but since it's only three strips long that
> didn't work too well either.


the xkcd one could simply work differently than the rest of them then, maybe. 
it doesn't really have to be tied accurately to a date, does it?

> - the caching may give us the same picture twice while browsing
> earlier strips when one was retrieved twice because no update happened
> for a day.


that's probably minor enough to be fine i'd think... 

> I don't know if Tobias has had a chance to look the patch over yet
> though. It doesn't seem to have been commited.


in the meantime, you could attach it to the bug report so that it doesn't get 
lost.