[Panel-devel] FlipLayout for review

[Aaron J. Seigo]

On Monday 10 December 2007, Ivan Čukić wrote:
> Aaron, here's another Lancelot -> Plasma port for review :)
>
> Cheers!
>
> p.s. The reason for FlipLayoutGlobal to hold the enum is to avoid enum
> access through a templated class.

put it in the Plasma namespace in plasma.h instead? and call them NoFlip, 
VerticalFlip, HorizontalFlip and .. uhm ... TotalFlip? dunno about that last 
one ;) and i don't think it *really* matters but it might be clearer if 
Both/TotalFlip/wathever was assigned VerticalFlip | HorizontalFlip ... i find 
that sort of thing makes stuff more self-documeting. you may also want to 
Q_DECLARE_FLAGS?

also ... if this is going into libplasma, then things like this:

if (m_flip == FlipLayoutGlobal::No) return;

need to be:

if (m_flip == FlipLayoutGlobal::No) {
    return;
}

=)

other 'n those details, it looks good!

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/f2dcf8e9/attachment.pgp