[Panel-devel] [PATCH] mousewheel on taskbar

[Aaron J. Seigo]

On Friday 07 December 2007, Marco Martin wrote:
> Hi all,
> this is an attempt to make possible to switch windows with the mousewheel
> on the taskbar

thanks =)

> it seems to work pretty weel, even if at the moment it only supports a
> taskbar with only a root group, but it shouldn't be difficult to make it
> support subgroups too

subgroup support would be needed, yes.

> don't know if it has some particular problem, any comments?

how well does this work with an empty taskbar, or if no windows are active? in 
particular the code in wheelEvent. seems like it will result in access to 
non-existing objects. probably needs some checks on _activeTask !+ -1 
and !_tasks.isEmpty(). 

can you also add some comments to the code in wheelEvent explaining exactly 
what it is doing there since it's obvious once you know the point and 
purpose, but .. yeah .. it's probably a bit mystical if you don't know that 
it's suppose to go the next event or to the previous one ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071207/737fd5ed/attachment-0001.pgp