[Panel-devel] [PATCH] Context menu and desktop widget locking

[Aaron J. Seigo]

On Sunday 02 December 2007, fonz2591 wrote:
> This patch enables the user to lock all widgets in plasma at once
> (similar to the "lock applets" feature of kicker).  Widget locking can
> be accessed through the desktop's context menu.  The patch also
> automatically adjusts the context menu when the desktop is locked
> (e.g. the text changes from "Lock Widgets" to "Unlock Widgets").
>
> I also made sure that all of the actions in the context menu have
> icons, which makes it look much nicer.

looks good;

+    if (corona()->isImmutable()) {
+        lockDesktop(false);
+    } else {
+        lockDesktop(true);
+    }

could just as well be lockDesktop(!corona()->isImmutable());

the immutable checks in workspace/libs/plasma/containment.cpp is a little 
messy, but accurate at least =)

> A problem is the "add widget" button in the tool box.  We need to
> figure out a way to hide that when corona's "immutable" is true.

yeah, we can make that aware of the actions being enabled or not.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071202/bbea650e/attachment.pgp