[Panel-devel] [PATCH] highlight active task in the taskbar

[Marco Martin]

On 12/1/07, Marco Martin <martkive at gmail.com> wrote:
> On Saturday 01 December 2007, Robert Knight wrote:
> >
> > red.  The colour scheme was changed and I cannot remember what the
> > effect looks like in the new scheme - it might need adjusting.
> > Unfortunately I have a dodgy checkout or local problem and Plasma
> > doesn't run at the moment so I cannot test.
>
> whoops :P
> at the moment what is the active task is not noticeable at all, so i assumed
> this wasn't supported...
> so now i will try to see if it's a colorscheme problem or if it's a bug
> somewhere

it seems that in the method AbstractTaskItem::drawBackround when a
task is TaskHasFocus and the mouse is not over that task,
_fadeTimer->currentValue() is always 0, so since alpha is computed
from that, it is also always 0
endColor.setAlphaF(qMin(1.0,startColor.alphaF()+0.2)); makes a
gradient with alpha from 0 to 0.2, absolutely not noticeable no matter
what the color scheme is.
i think that alpha should be changed to something like
alpha *= qMax(_fadeTimer->currentValue(), 0.3);
or alternatively a more opaque end color, with something like
endColor.setAlphaF(qMin(1.0,startColor.alphaF()+0.52));

Cheers,
Marco Martin