[Panel-devel] [PATCH] Beginnings of a panel implementation for discussion

[Robert Knight]

Hi,

Updated version of the patch attached in response to initial review by
richmoore.

- Better naming for a few private enums and methods
- Better comments in BoxLayout::Private
- Added support for spacing() and margin()
- Basic testing with nested layouts.

Regards,
Robert.

On 31/08/2007, Robert Knight <robertknight at gmail.com> wrote:
> Hi,
>
> Percy, thanks for doing this, but the current BoxLayout class still
> has some problems, mainly that it does not support the maximumSize()
> or minimumSize() constraints of layout items.  expandingDirections()
> turned out to be too crude to work in the task bar.
>
> I also think it is better for the main layout algorithm to be
> direction-agnostic with the direction-specific code elsewhere.  I had
> a look at Qt's layout engine and the code is surprisingly complex, we
> can probably get away with something less fancy though.
>
> The attached patch is my work-in-progress rewrite of BoxLayout which
> is 'good enough' for the Panel.  In addition to understanding
> maximumSize() and minimumSize() it also has RightToLeft and
> BottomToTop directions.  It currently ignores spacing() and margin() ,
> but I will fix that shortly.
>
> Regards,
> Robert.
>
> On 31/08/2007, Aaron J. Seigo <aseigo at kde.org> wrote:
> > On Thursday 30 August 2007, Percy Leonhardt wrote:
> > > On Thursday 23 August 2007, Matt Broadstone wrote:
> > > > If you've got it in you (and the time) please just do this, it will
> > > > make drop in replacement of QH/VBoxLayout when widgets on the canvas
> > > > works trivial.
> > >
> > > Finally I had the time to do this. Attached is a patch for the 3 layout
> > > classes.
> > >
> > > Can I commit this?
> >
> > sure thing.. very cool that you got around to this. less code! yay! =))
> >
> > --
> > Aaron J. Seigo
> > humru othro a kohnu se
> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
> >
> > KDE core developer sponsored by Trolltech
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rk_box_layout_v2.patch
Type: text/x-diff
Size: 22838 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070831/8f6993a8/attachment-0001.bin