[Panel-devel] [PATCH] Beginnings of a panel implementation for discussion

[Robert Knight]

Hi Percy,

Please commit.  I made those fixes locally but I have limited
connectivity this week so I am not committing as frequently as I
normally would.

Regards,
Robert.

On 23/08/07, Matt Broadstone <mbroadst at gmail.com> wrote:
> On 8/23/07, Percy Leonhardt <mailings at eris23.de> wrote:
> > On Thursday 23 August 2007, Matt Broadstone wrote:
> > > Looks good to me, but while you're at it get rid of that code dupe and
> > > move it into BoxLayout.
> >
> > But
> >
> >          hintHeight = qMax(hint.height(), hintHeight);
> >          hintWidth += hint.width() + spacing();
> >
> > and
> >
> >          hintWidth = qMax(hint.width(), hintWidth);
> >          hintHeight += hint.height() + spacing();
> >
> > are not really the same code. Only the second half of the functions are
> the
> > same:
> >
> >     hintWidth += 2 * margin();
> >     hintHeight += 2 * margin();
> >
> > Or should I go a step further and do what Aaron suggested:
> >
> > > they have been mostly. it's "just" the layout method that remains
> duplicated
> > > and that would be pretty easy to fix with a member variable in BoxLayout
> > > that records whether it is going horizontally or vertically, then HBox
> and
> > > VBox just because convenience classes more or less. iow, exactly how qt
> > > does it.
> >
> > If wanted I can try that.
> >
> If you've got it in you (and the time) please just do this, it will
> make drop in replacement of QH/VBoxLayout when widgets on the canvas
> works trivial.
>
> Matt
>
> >         Percy
> > _______________________________________________
> > Panel-devel mailing list
> > Panel-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/panel-devel
> >
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>