[Panel-devel] DataEngine and Corona patches

[Aaron J. Seigo]

On Tuesday 07 August 2007, Leo Franchi wrote:
> any my answer is basically that it managed to stop all Amarok dataengines
> from working.

what are the amarok dataengines doing? more specifically, what are they doing 
wrong? ;) sourceRequested *must* make the source if it returns true. in fact, 
here is the API documentation for sourceRequested:

         * When a source that does not currently exist is requested by the
         * consumer, this method is called to give the DataEngine the
         * opportunity to create one.
         *
         * The name of the data source (e.g. the source parameter passed into
         * setData) it must be the same as the name passed to sourceRequested
         * otherwise the requesting visualization may not receive notice of a
         * data update.
         *
         * @return true if a DataContainer was set up, false otherwise

are your data engines not doing this?

> The change calls d->source, telling it *not* to attempt to 
> create a datasource if it has to, even though we already know that the
> d->source( source, false ) call fails, because we already tried that. this

wrong. sourceRequested may result in the source being created. that's the 
whole point of calling sourceRequested and it returning a bool. if the engine 
can't create the source, then it returns false. otherwise, sourceRequested 
creates the source and returns true.

> patch has *no* side effects that I can see, i have been using it for the
> last week.

it creates empty DataSources that the engine has already said it can not 
fulfill.

> my second patch adds a Corona::clearApplets() function, so Corona-derived

this one is good, please commit.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070808/a26f4e24/attachment.pgp