[Panel-devel] Finished Junior Job

[Nathan Humbert]

On Monday 29 August 2005 12:19 am, Aaron J. Seigo wrote:
> On Monday 29 August 2005 12:03, Nathan Humbert wrote:
> > Everything compiles without complaint now and kicker seems to still run
> > without flying to pieces.
>
> in the taskbar part of the patch, the icon shouldn't be 1float ... it
> should probably use the same icon usage as if it were in a horizontal
> panel. ditto for applet handles.
>
Fixed the icon usage

> > I am not sure what is the best way to submit the
> > code, so I am just going to attach the svn diff results. Let me know if
> > there is a preferred method for submitting code.
>
> this is perfect =)

-- 
Nathan Humbert
humbna at cs.wwc.edu
egarim.homelinux.net
-------------- next part --------------
Index: taskbar/taskbar.cpp
===================================================================
--- taskbar/taskbar.cpp	(revision 454849)
+++ taskbar/taskbar.cpp	(working copy)
@@ -244,6 +244,10 @@
                 icon = "1rightarrow";
                 m_windowListButton->setMaximumWidth(BUTTON_MAX_WIDTH);
                 break;
+	    case Plasma::Floating:
+		icon = "1uparrow";
+		m_windowListButton->setMaximumWidth(BUTTON_MAX_WIDTH);
+		break;
         }
 
         m_windowListButton->setPixmap(kapp->iconLoader()->loadIcon(icon,
@@ -1230,6 +1234,10 @@
             icon = "1rightarrow";
             at = Qt::RightArrow;
             break;
+	case Plasma::Floating:
+	    icon = "1uparrow";
+	    at = Qt::UpArrow;
+	    break;
     }
 
     setArrowType(at);
Index: kicker/core/applethandle.cpp
===================================================================
--- kicker/core/applethandle.cpp	(revision 454849)
+++ kicker/core/applethandle.cpp	(working copy)
@@ -159,6 +159,10 @@
             m_layout->setDirection(QBoxLayout::LeftToRight);
             m_menuButton->setPixmap(xpmPixmap(right_xpm, "right"));
             break;
+	case Plasma::Floating:
+	    m_layout->setDirection(QBoxLayout::BottomToTop);
+	    m_menuButton->setPixmap(xpmPixmap(up_xpm, "up"));
+	    break;
     }
 
     m_layout->activate();
Index: applets/media/mediumbutton.cpp
===================================================================
--- applets/media/mediumbutton.cpp	(revision 454849)
+++ applets/media/mediumbutton.cpp	(working copy)
@@ -198,6 +198,9 @@
 	case Plasma::Left:
 		setPopupDirection(Plasma::Right);
 		break;
+	case Plasma::Floating:
+		setPopupDirection(Plasma::Floating);
+		break;
 	}
 }
 
Index: applets/trash/trashbutton.cpp
===================================================================
--- applets/trash/trashbutton.cpp	(revision 454849)
+++ applets/trash/trashbutton.cpp	(working copy)
@@ -149,6 +149,9 @@
 	case Plasma::Left:
 		setPopupDirection(Plasma::Right);
 		break;
+	case Plasma::Floating:
+		setPopupDirection(Plasma::Floating);
+		break;
 	}
 }
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20050830/8cd76b25/attachment.pgp