[Owncloud] [core files] [PATCH] : Adding Lazy Image Icons

[Thomas Müller]

Pull request is already there: https://github.com/owncloud/core/pull/6692

Thanks R Veach!

Am Mittwoch, den 08.01.2014 um 22:47 schrieb Georg Ehrke:
> Hi,
> that’s great.
> Can you please send a pull request on github. 
> see https://help.github.com/articles/using-pull-requests
> 
> Thanks,
> Georg Ehrke
> 
> On 08 Jan 2014, at 22:38, R Veach <rveach02 at gmail.com> wrote:
> 
> > I originally submitted a feature request for changing always loading file icon images to lazy loading them to save on bandwidth when opening a folder with many pictures inside it.
> > The original issue can be read here at https://github.com/owncloud/core/issues/6591 and all my reasoning for the need of this addition.
> >  
> > I have made small changes to the owncloud's core app "files" that achieves this functionality and am submitting it here so hopefully it can be incorporated.
> > The main addition is the JQuery Lazy Load library that I found at http://www.appelsiini.net/projects/lazyload , which can be used, as is, with no modifications. The library is released under the MIT License, which I believe it compatible with owncloud's APGL. Correct me if I am wrong.
> > The main changes to the file listing is replacing the background image style for the icon and putting it into a custom attribute that Lazy Load recognizes and works with.
> > The only other change is the call to the Lazy Load function in JS to monitor the user scrolling and position in the document.
> >  
> > I have tested this with owncloud 6.0.0a and found no issues in IE8 and FF26. The images that are not in view don't load when opening a directory (verified with firebug's net panel), the images are loaded correctly when scrolled into view, and cached images still show up rather instantly. I didn't see any problems with applying the changes to the master in git.
> >  
> > I have attached the patch using "diff -Naur".
> > "owncloudFilesOld" is the original core app files directory. "owncloudFilesLazy" is the core app files directory with my modifications for adding lazy load. The core app files directory is located in "owncloud\apps\files".
> > <owncloud lazy load patch.txt>_______________________________________________
> > Owncloud mailing list
> > Owncloud at kde.org
> > https://mail.kde.org/mailman/listinfo/owncloud
> 
> 
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud
>