[Owncloud] Introducing device tracking feature to ownCloud was: ideas for GSoC 2013

[Qingping Hou]

On Thu, Mar 14, 2013 at 5:35 AM, Bernhard Posselt <nukeawhale at gmail.com> wrote:
> First of, cheers and ty for using the framework :)
>
> I must admit defeat :D
>
> They say there are only two hard things in software development:
>
> * naming
> * caching
>
> It seems I failed in naming: You are the second person who turns of CSRF
> checks by copying(?) the main controller method comments. Was this your
> intention? If not i need to fix the comments in the apptemplate.
>

No, it's not your fault ;P I turned it on intentionly for demo purpose so I can
focus on implementing the core part. I will of course back on after I consider
the app is ready for production use.

> Some small things:
> * you can access POST variables by using $this->params('key') instead of
> $_POST['key'] in controllers. This helps you to write unittests ;)
> * theres a $this->renderJSON() shortcut for returning JSON
> * for a simple response, just use the Response object instead of
> TextResponse
>

Thanks a lot for your advice! Will appliy that to the app tonight :)