[Owncloud] [Proposal] A new architecture for handeling request and cleanup of lib/base

[Frank Karlitschek]

Hi Robin,


On 13.06.2013, at 16:11, Robin Appelman <icewind at owncloud.com> wrote:

> Currently the logic in lib/base.php and index.php haven't changed significantly 
> for a long time, there have been some additions such as routing but the basic 
> logic is simular as how it was years ago.

Which is a good thing. ;-)
It's stable and working well. Unlike other areas of ownCloud.


> This has the problem that that code in the way it's currently implemented is 
> very hard to test automatically, difficult to maintain and extend. This leads to 
> a situation where one of the most important parts of the code is a lot more 
> vulnerable to bugs then it should be.[1]

That's true. But I think the current problem is that no one is writing tests. There are plenty of opportunities where tests could be implemented and the structure of the code is not always the reason that is holding us back. ;-)



> To solve this problem and replace the current mess that is lib/base, I have, 
> with the help of some other developers,  created the following proposal for 
> the logic to handle request and replace the logic in lib/base
> 
> https://gist.github.com/icewind1991/5685072
> 
> The goal of the new system is to make a system that is testable, give apps 
> better options of integrating into core, generally cleaning up some of the 
> older systems currently in place and hopefully improve the overall quality of 
> the product we deliver

Let's talk about this at the developer meeting. 
I'm not so happy with another big restructuring that introduced new bugs. Let's fokus on the areas that really need attention.



Frank





> [1]: https://github.com/owncloud/core/pull/3487
> 
> - Robin Appelman
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud