[Owncloud] Fwd: Re: Files_Sharing Update

[Arthur Schiwon]

On Tuesday, September 25, 2012 09:25:50 PM Arthur Schiwon wrote:
> > Nothing should be echoed. So, that should be removed. There should still
> > be
> > a try/catch inside the update so we still go through each row. 
> 
> Yes, that's what already is going on. So we agree on this
> 
> > Exceptions
> >
> > are caught here:
> > 
> >
> > https://github.com/owncloud/core/blob/master/lib/app.php#L642
> >
> > 
> >
> > The exception on line 59 will be caught there.
> 
> And few lines later we die...
> 
> The handling with failing updates is double-plus-user-unfriendly in
> newspeak,  but that's something for the future. That's why we should avoid
> ending up in throwing exceptions at the end of the update script, if
> possible.

done in 0192d920f05f231018500abf637d9877d779d5b9

Cheers
Arthur