[Owncloud] Fwd: Re: Files_Sharing Update

[Arthur Schiwon]

and to the list

----------  Forwarded Message  ----------

Subject: Re: [Owncloud] Files_Sharing Update
Date: Tuesday, September 25, 2012, 05:49:20 PM
From: Arthur Schiwon <blizzz at owncloud.com>
To: Michael Gapczynski <mtgap at owncloud.com>

On Tuesday, September 25, 2012 11:17:29 AM you wrote:
> Thanks for working on this Arthur. I'm not quite sure what's going on with
> the user backends not setup because I haven't run into any of those issues
> myself. It seemed that the database user backend was always running when I
> did an upgrade. This should probably be documented somewhere or the user
> backends loaded before triggering an upgrade.

I agree I was puzzled bout it. I believe it is because it's an major upgrade 
which is done in init() before the user backends are created and which also 
takes the apps into account. 

> What do you mean that there will be collisions with the old table still
> existing? Nothing should be using the oc_sharing table. 

I was a bit unprecise. When the update is not successful, it will be tried all 
over again on the next page request. The already transfered shares will flood 
then the screen with error messages like "already exists" and fail again.

> I didn't want to
> delete it this release in case there were upgrade issues, which there are ;)
> If we do a 4.5.1 and no issues are reported we can delete it then. No harm
> in having it sit around.
> 
> Can you give more details about the rows being added for links?
In the old table i have had
+-----------+-----------------+---------------------------------------------------------------+------------------------------------------+-------------+
| uid_owner | uid_shared_with | source                                                        
| target                                   | permissions |
+-----------+-----------------+---------------------------------------------------------------+------------------------------------------+-------------+
| nata      | public          | /path/to/shared/folder | 
4d24e8c45f5f198f628a34547b1176e4f223497a |           0 |
| arthur    | public          | /path/to/shared/folder | 
4d24e8c45f5f198f628a34547b1176e4f223497a |           0 |
| arthur    | public          | /path/to/shared/folder | 
4d24e8c45f5f198f628a34547b1176e4f223497a |           0 |
+-----------+-----------------+---------------------------------------------------------------+------------------------------------------+-------------+
(here one row is already doubled, because in 4.0.7  the link was not  shown in 
the GUI for me – so i clicked it again)

In the new share table however i do not see any shares of the item type "link" 
or similar. How are they stored?

However, the new link looks like 
https://owncloud.server/public.php?service=files&file=/path/to/shared/folder

the old link was:
https://owncloud.server/public.php?service=files&token=20288a20dd02750f81d2307e32bd367dcda331b6&file=/path/to/shared/folder

Does it help you?

Cheers
Arthur



> 
> 
> Michael
> 
> On Tuesday, September 25, 2012 12:35:10 PM Arthur Schiwon wrote:
> > Hey,
> > 
> > i spent now some time to fix my trouble with the upgrade from 4.0.7 to 4.5
> > with Files_Sharing. There were more issues for me than initially found.
> > 
> > First,  I got errors because OC_FileSystem was not initialized, then the
> > user backends where not available. This is fixed with
> > 15e02726d76555ea9eb2dd59a88d2310bcd9b08c I hope it makes sense.
> > 
> > Then the old reshares made the update script fail. I fixed it with
> > 80fde2d8d1a0f70a62416241a9bf9c8e4f0ac489. Doing so, the Reshares will be
> > recreated. Again I hope that makes sense.
> > 
> > Now, I was hit by the error that a file has been shared twice with a
> > public
> > link, this will make the update script also break. Since it isyou can’t
> > find
> any oxygen from outside the aircraft to get in the aircraft more or less
> 
> > OK now (the Shared link will be done) I am fine with a notice about that.
> > However, an exception is thrown on error, i.e. white page with error
> > messages for the user and no finished Update. For me I solved it by
> > replacing the Exception with the OCP\Util::writeLog.
> > I hesitated to push it to master, yet.
> > 
> > The last thing is that the old table is not deleted (it is prepared,
> > though, i uncommented it for me). As long as the table persists and the
> > entries are in the new table, new collission will occur. As long as the
> > Exception is thrown, it will make things worse.
> > I pledge for using writeLog and removing (or at least renaming) of the
> > table. I leave this to Michael.
> > 
> > And last thing: the old public links do not work anymore. I have no idea
> > how to fix it.
> > 
> > Cheers
> > Arthur
> > _______________________________________________
> > Owncloud mailing list
> > Owncloud at kde.org
> > https://mail.kde.org/mailman/listinfo/owncloud
-----------------------------------------