[Owncloud] Public sharing and password protection broken in 4.5.3 ?

[Christian Schwerdt]

Hi,

smae problem with errors at the top of the page.

This was my fix: replace $_GET['path'] with $getPath in line 236:


Index: public.php
===================================================================
--- public.php	(revision 37)
+++ public.php	(working copy)
@@ -233,7 +233,7 @@
  			$breadcrumb[] = array('dir' => '/', 'name' => basename($basePath));

  			//add subdir breadcrumbs
-			foreach (explode('/', urldecode($_GET['path'])) as $i) {
+			foreach (explode('/', urldecode($getPath)) as $i) {
  				if ($i != '') {
  					$pathtohere .= '/'.$i;
  					$breadcrumb[] = array('dir' => $pathtohere, 'name' => $i);


Am 30.11.2012 04:10, schrieb Erik R:
> Sharing a folder with lots of files in it gives me these errors at the
> top of the page:
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *165*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *166*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *164*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *165*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *166*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *164*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *165*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *166*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *164*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *165*
>
> *Warning*: Cannot modify header information - headers already sent by
> (output started at
> /home/slmmr/public_html/oc/apps/files_sharing/public.php:236) in
> */home/slmmr/public_html/oc/lib/template.php* on line *166*
> *
> *
> *Also, when I try to password protect the share, it doesn't take effect.*
>
>
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud