[Owncloud] Closing PHP tags was: Re: Broken images ....

[Thomas Mayer]

Hi,

I just wanted to say, that a lot of PHP coding standards recommend to omit the closing ?>, when the file only contains PHP code.

Maybe Owncloud should adopt that into the style guide.

http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
http://drupal.org/coding-standards#phptags
http://docs.joomla.org/Coding_style_and_standards#PHP_Code_Tags

Best regards,
Thomas

----- Original Message -----
From: thomas.mueller at tmit.eu
To: victor.dubiniuk at gmail.com, owncloud at kde.org
Date: 22.05.2012 13:12:56
Subject: Re: [Owncloud] Broken images ....


> 
> Fixed here:
> https://gitorious.org/owncloud/apps/commit/07d7f438ca1da5d8488618bb26c57287360abc32
> 
> Thanks a lot Victor for pointing me there!
> 
> @Frank:
> Merge request for OC4.0.1
> 
> THX,
> 
> Thomas
> 
> -- 
> Thomas Müller                 E-Mail: thomas.mueller at tmit.eu
> 
> Am Dienstag, dem 22.05.2012 um 12:40 schrieb Victor Dubiniuk:
>> Hi Thomas,
>> 
>> remove the closing  ?>
>> in the file  apps/files_odfviewer/appinfo/app.php
>> to fix it.
>> 
>> 
>> ----
>> Victor Dubiniuk
>> victor.dubiniuk at gmail.com
>> http://www.linkedin.com/in/vicdeo
>> 
>> On Tue, May 22, 2012 at 2:14 AM, Thomas Müller <thomas.mueller at tmit.eu>wrote:
>> 
>> > Hi,
>> >
>> > has anybody of you deeper knowledge about php-gd?
>> >
>> > One of my ownCloud installation (done with the Debian package) is
>> > returning broken images for e.g.
>> >
>> > http://localhost/owncloud-git/?app=gallery&getfile=ajax/thumbnail.php?img=/Winter.jpg
>> >
>> > The thumbnail itself exists on both installations and it is posted back to
>> > the browser.
>> >
>> > The only difference is a new line between the content length and the data.
>> > This new line causes the browser not to show the image.
>> >
>> > Here is the interesting part of the working response:
>> > Transfer-Encoding: chunked
>> > Content-Type: image/jpeg
>> >
>> > 2000
>> > ......JFIF.............>CREATOR: gd-jpeg v1.0 (using IJG JPEG v80),
>> > default quality
>> >
>> > and here the broken repsonse:
>> > Transfer-Encoding: chunked
>> > Content-Type: image/jpeg
>> >
>> > 2001
>> >
>> > ......JFIF.............>CREATOR: gd-jpeg v1.0 (using IJG JPEG v80),
>> > default quality
>> >
>> > I appreciate any response and idea how to fix this issue!
>> >
>> > Thanks a lot,
>> >
>> >
>> > Thomas
>> >
>> > --
>> > Thomas Müller                 E-Mail: thomas.mueller at tmit.eu
>> >
>> > _______________________________________________
>> > Owncloud mailing list
>> > Owncloud at kde.org
>> > https://mail.kde.org/mailman/listinfo/owncloud
>> >
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud