[Owncloud] Code review? OC_Image class

[Bartek Przybylski]

howdy!
One more thing,in function _output in switch as default action you are
handling given file as png.
however afaik only scenario in which this action will be triggered is
that a given file is TIFF file, other should be recognize, so o think
you could just do $retval = false

do you agree?

bartek

2012/1/2 Robin Appelman <icewind1991 at gmail.com>:
> Yes, there is no reason for it to be static.
>
> - Robin Appelman
>
>
>
> On Mon, Jan 2, 2012 at 00:02, Thomas Olsen <thomas at tanghus.net> wrote:
>> On Sunday 01 January 2012 23:58 Robin Appelman wrote:
>>> "// if($this->valid()) { // FIXME: I get an error: "PHP Fatal error:
>>> Using $this when not in object context..." WTF?"
>>>
>>> the function loadFromFile is static, so while in that function you're
>>> not in object context.
>>
>> Facepalm - Thanks :-)
>>
>> So I'd better make it non-static, right?
>>
>> --
>> Med venlig hilsen / Best Regards
>>
>> Thomas Olsen
>> _______________________________________________
>> Owncloud mailing list
>> Owncloud at kde.org
>> https://mail.kde.org/mailman/listinfo/owncloud
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud