[Owncloud] Code review? OC_Image class

[Robin Appelman]

"// if($this->valid()) { // FIXME: I get an error: "PHP Fatal error:
Using $this when not in object context..." WTF?"

the function loadFromFile is static, so while in that function you're
not in object context.

- Robin Appelman



On Sun, Jan 1, 2012 at 23:40, Thomas Olsen <thomas at tanghus.net> wrote:
> On Sunday 01 January 2012 19:38 Thomas Olsen wrote:
>> > > On Sun, Jan 1, 2012 at 18:27, Bartek Przybylski
>> > > <bart.p.pl at gmail.com> > >>
>> > >> mayba add function put(resource, x, y, w, h) which will copy local
>> > >> resource to given resource on coordins x and y and crop it to h
>> > >> and w
>> > >> dimentions ?
>>
>> I like that :-) Crop the local resource before copying it to the image or
>> crop the image afterwards?
>
> OK. All changes except the above - which I can always add given a use case for
> it - is in this commit: http://is.gd/bGkIa0
>
> --
> Med venlig hilsen / Best Regards
>
> Thomas Tanghus
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud