[Owncloud] Re: Review Request: When moving a file from a temporary location, also update the file access/modification times.

[Matthew John Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100853/
-----------------------------------------------------------

(Updated March 16, 2011, 3:38 a.m.)


Review request for ownCloud.


Changes
-------

Add the same code to toTmpFile.  It doesn't appear to do anything, probably due to permission problems, but it doesn't cause any extra warning or failures.


Summary
-------

When PHP moves a file across filesystem boundaries, it does not update the access/modification times.  Thus do it manually so that this information is not lost.


Diffs (updated)
-----

  inc/lib_filestorage.php 06ce26f0d23df0414883152a14e027ac405701f7 

Diff: http://git.reviewboard.kde.org/r/100853/diff


Testing
-------

Tested with moving with /tmp and owncloud's data directory being on different filesystems.  Also tested with file being on the same filesystem.  In both cases data was preserved.


Thanks,

Matthew John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20110316/70928a16/attachment.html>