[Owncloud] Review Request: Separation of core app config records from their custom config entries

Kamil DomaƄski kdomanski at kdemail.net
Sat Jun 18 03:05:20 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101668/
-----------------------------------------------------------

Review request for ownCloud.


Summary
-------

This patch separates custom app configuration records (oc_appconfig) from core app settings (in newly created oc_apps table). The new table contains app id, version string and activation status (boolean) in a single record for each application.

Removal function now removes both core and custom records.
New getApps() now returns apps from core config.
Old getApps() renamed to getAppsUsingConfig().
Installation status now checked with OC_APPCONFIG::isInstalled($app).
Installer now uses new OC_APPCONFIG::installAPP(...) function.
Installer now checks for both existing folder and config record before installing.


Diffs
-----

  db_structure.xml 599352c 
  lib/app.php e373331 
  lib/appconfig.php 4fef754 
  lib/installer.php 7ab07bf 

Diff: http://git.reviewboard.kde.org/r/101668/diff


Testing
-------

No problems detected.


Thanks,

Kamil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20110618/f419730a/attachment.html>


More information about the Owncloud mailing list