[Owncloud] Re: Review Request: fix warnings

[Robin Appelman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101549/#review3796
-----------------------------------------------------------

Ship it!


Looks good to me.

- Robin


On June 8, 2011, 9:10 p.m., Thomas Zander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101549/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 9:10 p.m.)
> 
> 
> Review request for ownCloud.
> 
> 
> Summary
> -------
> 
> Fix many warnings in 3rd party stuff which is due to that code seemingly not using the php5 opcodes
> 
> 
> Diffs
> -----
> 
>   3dparty/MDB2.php 30e564f 
>   3dparty/MDB2/Schema/Parser.php bd7a965 
>   3dparty/MDB2/Schema/Validate.php 21be024 
>   3dparty/PEAR.php 9760b9d 
> 
> Diff: http://git.reviewboard.kde.org/r/101549/diff
> 
> 
> Testing
> -------
> 
> Warnings went away and functionality looks Ok to me...
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20110609/632f8f89/attachment.html>