[Owncloud] Re: ownCloud commit

[Jakob Sack]

Hello Hans, hello list,

I think that it is a good idea to put the javascript and css requirements 
(addStyle, addScript) on top of the template files. In my opinion both are part 
of the view and not of the controller.
What do others think?
Cheers,

Jakob

Am Freitag, 8. Juli 2011, 18:59:22 schrieben Sie:
> The javascript code is changed to jQuery now. It does not call the code on
> page load yet, I think that should be done when the html is generated on
> the server?
> 
> I'll wait for your response about OC_UTIL::addScript('files','**admin');.
> 
> Kind regards,
> 
> Hans
> 
> 2011/7/8 Hans Bakker <hansmbakker at gmail.com>
> 
> > By the way, shouldn't OC_UTIL::addScript('files','**admin'); end up in
> > files/templates/admin.php??
> > 
> > 
> > 2011/7/7 Hans Bakker <hansmbakker at gmail.com>
> > 
> >> Hello Jakob,
> >> 
> >> thank you for your feedback!
> >> 
> >> As for jQuery, I hadn't realized that you're depending on it. I'll
> >> improve my commit probably this weekend.
> >> 
> >>  I didn't know if someone was working on the mockup, either, but I just
> >> 
> >> thought that it would make someone else's work easier or it might
> >> trigger somebody to start working on it :).
> >> 
> >> At least it's more usable and it looks better now.
> >> 
> >> Cheers,
> >> 
> >> Hans
> >> 
> >> 
> >> 2011/7/4 Jakob Sack <mail at jakobsack.de>
> >> 
> >>> Hello Hans,
> >>> 
> >>> I just had a look at your owncloud commit 1daeb13d. Do you have a
> >>> reason for not using jQuery? We try to use jQuery where possible and
> >>> put javascript in js files, in this case you could add
> >>> "OC_UTIL::addScript('files','**admin');" to files/admin.php and put
> >>> the code in files/js/admin.js.
> >>> By the way you improved one of my early mockups, I don't know if anyone
> >>> is working on these features for real :-/
> >>> Thank you for contributing to ownCloud!
> >>> Cheers,
> >>> 
> >>> Jakob