[Owncloud] Review Request: File actions broken in rekonq, konqueror, and opera (maybe more) since undo delete function

Michael Gapczynski gapczynskim at gmail.com
Sun Aug 28 00:00:33 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102463/#review6084
-----------------------------------------------------------

Ship it!


Tested and it works. Thanks Bart. 

- Michael


On Aug. 27, 2011, 7:52 p.m., Bart Visscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102463/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 7:52 p.m.)
> 
> 
> Review request for ownCloud.
> 
> 
> Summary
> -------
> 
> File actions broken in rekonq, konqueror, and opera (maybe more) since undo delete function.
> 
> This was broken by the use of the name 'delete', it is (now?) a keyword. Renamed the function to do_delete, and now it works.
> 
> 
> Diffs
> -----
> 
>   files/js/fileactions.js 04943abf74a71f5c5c996e76ea6e45aa1cde9195 
>   files/js/filelist.js a776b7bce08d385bb48575223bc095c9180cd2ba 
>   files/js/files.js baf8debf48b8a302337c329dd6722983adaeb91b 
> 
> Diff: http://git.reviewboard.kde.org/r/102463/diff
> 
> 
> Testing
> -------
> 
> Tested with rekonq, files actions work now
> 
> 
> Thanks,
> 
> Bart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20110828/489f11bb/attachment.html>


More information about the Owncloud mailing list