[Owncloud] a patch for updating bookmarks list

[Golnaz Nilieh]

I have applied my patch to master branch after Jan first reply,
But I will fix it now, Thanks for your guidance :)

On Fri, Aug 19, 2011 at 3:16 PM, Jan-Christoph Borchardt <
JanCBorchardt at fsfe.org> wrote:

> Oh and another thing:
> Please always use single quotes in JavaScript (same goes for PHP). Then
> you don’t have to escape the HTML double quotes.
>
>
> On Fri, August 19, 2011 12:24, blizzz at arthur-schiwon.de wrote:
> >
> > Hi Golnaz,
> >
> > thanks a lot for your patch! That thing annoyed me, too, but have not yet
> > found time to fix it. So that's great!
> >
> > Please follow Jans adivce on how to get it in :)
> >
> > Additionally, I have had a short look into the patch and have two wishes
> > for improvement:
> > 1) could you please link the tags to ?tag=TAG ? Because they can be
> > filtered :)
> > 2) could you please use encodeEntities() when putting out foreign text to
> > the page to prevent JS insertion?
> > You can see how updateBookmarksList() utilizes both.
> >
> > Thx + Cheers
> > Arthur
> >
> > On Fri, 19 Aug 2011 13:55:18 +0430, Golnaz Nilieh
> > <golnaz.nilieh at gmail.com>
> > wrote:
> >> Hi,
> >> I have created a patch for bookmarks section. It shows the bookmark
> > entry
> >> in
> >> the list immediately after insertion, And hides it after deletion; using
> >> some javascript code.
> >>
> >> I do have write access to KDE repos, Is it ok to send a patch for each
> > fix,
> >> or I should do fixes in a separate branch and request for merging with
> >> master? In fact, It is good to have contribution policies documented.
> > _______________________________________________
> > Owncloud mailing list
> > Owncloud at kde.org
> > https://mail.kde.org/mailman/listinfo/owncloud
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20110819/338435c5/attachment.html>