[okular] [Bug 443403] Reduce the size of the digital signature display

Nicolas Fella bugzilla_noreply at kde.org
Thu Sep 12 14:00:34 BST 2024


https://bugs.kde.org/show_bug.cgi?id=443403

--- Comment #39 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit e165180bb0db38e780e7fcd425cff186f48abd12 by Nicolas Fella.
Committed on 12/09/2024 at 12:54.
Pushed by aacid into branch 'master'.

Rework UX for adding digital signature

Currently when adding a signature the user is prompted to specify a
rectangle, then chose a certificate. The problem here is that the
user doesn't know what size is appropriate, so it takes some trial and
error to get something good.

To address this change the flow a bit. First ask which certificate and
other parameters should be used. With that information we create a
signature annotation object and add that to the page. The user can
then move and resize it like any annotation util the size and placement
is right.

Once the user is happy with the placement they click on a Finish Signing
button that then prompts for where to save the signed document and signs
it.

This makes the warning about a too small signature rect redundant since
the user sees that the signature won't fit. It was only an approximation
anyway.

M  +6    -0    CMakeLists.txt
M  +133  -0    core/annotations.cpp
M  +56   -0    core/annotations.h
M  +6    -0    core/document.cpp
M  +5    -0    core/document.h
M  +8    -0    core/signatureutils.h
M  +50   -0    generators/poppler/annots.cpp
M  +47   -1    part/pageview.cpp
M  +10   -0    part/pageview.h
M  +133  -45   part/pageviewannotator.cpp
M  +4    -0    part/pageviewannotator.h
M  +23   -0    part/part.cpp
M  +6    -0    part/part.h
M  +1    -0    shell/shell.cpp

https://invent.kde.org/graphics/okular/-/commit/e165180bb0db38e780e7fcd425cff186f48abd12

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list