[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=402017

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |23.04.1
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/b5191a2c
                   |                            |1fa8f4ce45e36258942c6157a37
                   |                            |99e7a
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #73 from Nate Graham <nate at kde.org> ---
Git commit b5191a2c1fa8f4ce45e36258942c6157a3799e7a by Nate Graham.
Committed on 02/05/2023 at 20:57.
Pushed by ngraham into branch 'master'.

Let user "Save As..." when document has been externally modified

Currently Okular stops the user from saving their document if it has
unsaved changes and was modified externally. This makes some sense
because there are now two sources of truth, and Okular cannot reconcile
them itself. However as a consequence, it causes data loss since the
user's unsaved changes in Okular become un-save-able. This is quite
frustrating when it happens.

But this prohibiton on saving over an externally-modified document only
really makes sense for a "Save" operation that overwrites the original
document. If instead, the user does a "Save As...", then they can save
their local changes to another file and avoid losing unsaved changes.
Then if needed, they can manually compare the original
externally-modified document with their newly-saved document and
reconcile the changes by hand.

Accordingly, this commit avoids showing the error message box and
blocking saving if the user is doing a "Save As..." to a new location,
rather than overwriting the open file.
FIXED-IN: 23.04.1

M  +3    -1    part/part.cpp

https://invent.kde.org/graphics/okular/commit/b5191a2c1fa8f4ce45e36258942c6157a3799e7a

-- 
You are receiving this mail because:
You are the assignee for the bug.