[okular] [Bug 468317] New: Duplicated 'show sidebar' action

[Kishore Gopalakrishnan]

https://bugs.kde.org/show_bug.cgi?id=468317

            Bug ID: 468317
           Summary: Duplicated 'show sidebar' action
    Classification: Applications
           Product: okular
           Version: 23.03.90
          Platform: Other
                OS: Other
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: okular-devel at kde.org
          Reporter: kishore96 at gmail.com
  Target Milestone: ---

Created attachment 157971
  --> https://bugs.kde.org/attachment.cgi?id=157971&action=edit
Screenshot of the duplicated entries in the keyboard shortcuts dialog

SUMMARY
In 'Settings > Configure Keyboard Shortcuts', I see two items called 'show
sidebar', but only one of them works (the other one does not affect the sidebar
even when a keyboard shortcut is assigned to it).

Similarly, there are two 'show sidebar' actions in the list of available
toolbar buttons, only one of which works.

STEPS TO REPRODUCE
Part A (duplicated keyboard shortcut)
1. Settings > Configure Keyboard shortcuts
2. Search for 'sidebar'

Part B (duplicated toolbar entry)
1. Right-click on Okular toolbar > Configure toolbars
2. In 'main toolbar <okular_shell>', search for 'show sidebar'
3. In 'main toolbar <okular_part>', search for 'show sidebar'
4. Place the 'show sidebar item in <okular_part> onto the toolbar and save
changes
5. Try to find the new 'show sidebar' button on the toolbar

OBSERVED RESULT
Part A: Two items called 'show sidebar' (see attached screenshot), one of which
does nothing when a keyboard shortcut is assigned to it
Part B: Only the show sidebar item in okular_shell works, while the other one
shows no button even if placed on the toolbar.

EXPECTED RESULT
Only one 'show sidebar' item

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.10-arch1-1 (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
This is reproducible even in a fresh user account, so it does not seem to be an
issue of stale config files

Bug is reproducible on Arch Linux with Okular versions 23.08.80 and 23.08.90

Git bisect points to
2fbab13e1f439f0dd2c6758d51c80e86ee49392a is the first bad commit
commit 2fbab13e1f439f0dd2c6758d51c80e86ee49392a
Author: Eugene Popov <popov895 at ukr.net>
Date:   Thu Dec 22 22:50:55 2022 +0000

    Port sidebar to QDockWidget

    With this MR, the sidebar can now be (if not locked):
    * docked to the left or right side
    * undocked and floated as an independent window
    * closed with the close button in the header

    BUG: 455013

 interfaces/viewerinterface.h |   7 ++
 part/part.cpp                |   5 ++
 part/part.h                  |   1 +
 part/sidebar.cpp             |   5 ++
 part/sidebar.h               |   2 +
 shell/shell.cpp              | 162 ++++++++++++++++++++++++++++++++++++++++++-
 shell/shell.h                |   6 +-
 shell/shell.rc               |   7 +-
 8 files changed, 192 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.