[okular] [Bug 456381] New: Respect Config Option to Not Notify about Embedded Signatures

[Billy McCann]

https://bugs.kde.org/show_bug.cgi?id=456381

            Bug ID: 456381
           Summary: Respect Config Option to Not Notify about Embedded
                    Signatures
           Product: okular
           Version: 22.04.2
          Platform: Archlinux Packages
                OS: Linux
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: okular-devel at kde.org
          Reporter: thebillywayne at gmail.com
  Target Milestone: ---

SUMMARY
***
Okular gives a notification regarding the signatures of digitally signed pdfs
irrespective of gui configuration. When "Notify about embedded files, forms, or
signatures" is true, notifications regarding all three about will be displayed.
Yet if this option is turned off, notifications about signatures still appear
while those for embedded files and forms do not. Hence, notifications about
signatures are displayed irrespective of the configuration, which other
notifications are suppressed as per the configuration. Suggest patching
`gui/signatureguiutils.cpp`.
***


STEPS TO REPRODUCE
1. Ensure that "Settings > Configure Okular > General Options > Notify about
embedded files, forms, or signatures" is checked. 
2. Open a pdf with both forms and a digital signature. 
3. Observe notifications about both forms and signature.
4. Change settings such that "Settings > Configure Okular > General Options >
Notify about embedded files, forms, or signatures" is no longer checked.
6. Observe notifications about only the signature and not forms. 

OBSERVED RESULT
Notifications about signatures is observed even though "Notify about embedded
files, forms, or signatures" is not checked in the options. However, all
notifications are observed if the option is checked. 

EXPECTED RESULT
No notifications regarding embedded files, forms or signatures if the option is
unchecked. Expect notifications regarding signatures to be suppressed along
with others. 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Linux 5.18.8
KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Suggest adding logic to `if (anySignatureUnsighted)` conditional beginning on
line 204 of `gui/signatureguiutils.cpp` to check preferences.

-- 
You are receiving this mail because:
You are the assignee for the bug.