add a commandline flag for dynamically specifying reverse-search editor command

[Andreas Naumann]

On 24.01.22 23:33, Albert Astals Cid wrote:
> El dilluns, 24 de gener de 2022, a les 22:51:49 (CET), Andreas Naumann va escriure:
>> Hey all okular developers,
>>
>> please let me first introduce my self, since i am new to the list.
>>
>> My name is Andreas and I am from Germany. I do have several years
>> experience in (scientific) Softwaredevelopment with C++. Since I use the
>> KDE desktop quite regularly, I thought, I could also give something back
>> to the community.
>>
>> So, I was looking for some task, I am interested in and which also
>> serves as a starting point to learn the code base.
>>
>> Thus I selected the bug263732 <https://bugs.kde.org/show_bug.cgi?id=263732>
>>
>> During studying the code and trying to fix it, I asked myself some
>> question on the code and workflow:
>>
>> 1. The commandline is parsed by the commandline parser from Qt. But the
>> arguments are passed around using a string. Everytime a function needs
>> to check for an argument, it deserializes the string to retrieve the value.
>>
>> That workflow has the advantage, that it requires only a QString to pass
>> the data to other functions.
>> I prefer to have a data structure, which contains the arguments as fields.
>>
>> Is there any other disadvantage in using a struct instead of a string?
> You can't pass a struct to an already running instance of okular.
> Well, yes you can, serializing it, which is what we do.
>
>> 2. Several tests fail. Is that intended, or forgotten? I did not yet dig
>> deeper into the codebase to understand, what the tests do.
> Tests should all mostly pass, what failures do you get?:

ctest -j2 gives:

           2 - kimgiotest (Failed)
           6 - documenttest (SEGFAULT)
           7 - searchtest (SEGFAULT)
          10 - editannotationcontentstest (Failed)
          11 - addremoveannotationtest (Failed)
          12 - translateannotationtest (Failed)
          13 - modifyannotationpropertiestest (Failed)
          14 - editformstest (Failed)
          16 - mainshelltest (SEGFAULT)
          17 - annotationtoolbartest (SEGFAULT)

lsb_release -a:

    Distributor ID: Neon
    Description: KDE neon Unstable Edition
    Release:    20.04
    Codename:  focal

git show -s HEAD:  commit 44c86de7e415e30572d774a3ec3e90681bc8abfa (HEAD
-> release/21.12, origin/release/21.12)


I appended the test result from cmake.

Greetings,
Andreas


>
> Cheers,
>    Albert
>
>>
>> Greetings,
>> Andreas
>>
>>
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LastTest.log
Type: text/x-log
Size: 43200 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20220125/77c72f04/attachment-0001.bin>