[okular] [Bug 450347] MiniBar in toolbar is broken on master

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=450347

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/9432565e
                   |                            |de1599baf9484e66a2f1a335f33
                   |                            |8cfef
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Albert Astals Cid <aacid at kde.org> ---
Git commit 9432565ede1599baf9484e66a2f1a335f338cfef by Albert Astals Cid, on
behalf of snooxx 💤.
Committed on 22/02/2022 at 23:16.
Pushed by aacid into branch 'master'.

Fix broken page MiniBar

The `MiniBar` normally used to display page numbers and to provide
navigation buttons regressed since 01557c16c4 to only show an empty
non-functional button called "Page Number", along with multiple
warnings:
`QObject::connect(MiniBar, QAction): invalid nullptr parameter`

This is caused by moving `setupViewerActions()` to a place where
`m_miniBar` is not initialized yet, even though it has a runtime
`connect`-dependency on it.

By moving `setupViewerActions()` back, the `MiniBar` starts working
again. Now the `m_addBookmark` action, which is created in that
function, is not available anymore to be passed to the constructor of
`BookmarkList`. To avoid moving the setup of the latter away from the
rest of the sidebar code, only assigning the action to the bookmark
button contained in the `BookmarkList` is deferred to
`setupViewerActions()`.

As requested, any accidental future `nullptr`-access will be handled by
crashing, even in Release builds, by omitting any checks.

Test Plan:

Page numbers show up again in toolbar, no more `connect` warnings.

M  +10   -6    part/bookmarklist.cpp
M  +5    -1    part/bookmarklist.h
M  +4    -3    part/part.cpp

https://invent.kde.org/graphics/okular/commit/9432565ede1599baf9484e66a2f1a335f338cfef

-- 
You are receiving this mail because:
You are the assignee for the bug.