[okular] [Bug 342094] State of side Navigation Panel is not not remembered

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=342094

--- Comment #10 from Albert Astals Cid <aacid at kde.org> ---
(In reply to andrea.ippo from comment #9)
> I'm not really sure this is a junior job.
> 
> I haven't downloaded the code yet, but checking:
> 
> https://github.com/KDE/okular/blob/1dc81340bcfecf054f27c17279cb241316a7c16c/
> core/document.cpp
> 
> it seems to me that the code that handles per-document properties is not the
> right place to handle app UI properties, I guess this was by design.
> 
> I also dunno exactly what are the rendering steps once a document is opened
> in okular: I would guess that first the app UI is rendered, with or without
> left panel depending on the "global" settings persisted in:
> 
> ~/.config/okularpartrc
> 
> And only once the "frame" is in place, document rendering takes place,
> according to its specific view settings (persisted on a document basis).
> 
> So IMO to achieve what's requested by the logger, this process should be
> reviewed, either by delaying rendering of part of the app UI, or by drawing
> it with some defaults/global state, and then re-draw the left panel
> according to per-document settings, if any are stored (which could cause
> some re-rendering glitches, I guess?)
> 
> Also, I dunno whether left panel properties (on/off and tab id) could be
> stored in the per-document XML file within a <view name=LeftPanel> element,
> for example.
> 
> Is there an XSD defining the structure of documentInfo?
> 
> <documentInfo url="/home/andrea/Documents/Casa/Diagnostiques/2043 (DIAG
> ELEC).pdf">
>  <generalInfo>
>   <history>
>    <oldPage viewport="0;C2:0.499767:0.209379:1"/>
>    <current viewport="3;C2:0.499803:0.545531:1"/>
>   </history>
>   <views>
>    <view name="PageView">
>     <zoom mode="1" value="2.47816"/>
>     <continuous mode="1"/>
>     <viewMode mode="0"/>
>     <trimMargins value="0"/>
>    </view>
>   </views>
>  </generalInfo>
> </documentInfo>

I think you didn't understand what the user wants at all, they only want that
if the last time they were open a document it was on thumbnails, open again in
thumbnails not in contents, there's no need for changing anything render
related *at all*.

The only question is if would do this globally or per file, but that only means
the setting is change in one place or the other.

-- 
You are receiving this mail because:
You are the assignee for the bug.