[okular] [Bug 442503] Scroll Page Up teleports to top of previous page

[Wouter M. Koolen]

https://bugs.kde.org/show_bug.cgi?id=442503

--- Comment #11 from Wouter M. Koolen <onkekabonke at hotmail.com> ---
Dear David,

Sure!

61551d2356ea5f93ba3e921a1c4ab9cca88fdbda is the first bad commit
commit 61551d2356ea5f93ba3e921a1c4ab9cca88fdbda
Author: Gerd Wachsmuth <gerd.wachsmuth at b-tu.de>
Date:   Thu Apr 1 11:58:53 2021 +0200

     Fix: Viewport coords normalized w.r.t. full page

     The coordinates in Viewport.rePos are normalized on the full page. In
     two functions within pageview.cpp, these were treated as coordinates on
     the cropped page.

     CCBUG: 198427

     This partially fixes the bug 198427 in the case that the cropping 
of the
     target pages (and the pages around the target) is known at the time the
     link is clicked. That is, it works if

     - One uses 'Trim To Selection'
     - One uses 'Trim To Margin' and has already viewed at the target
     page(s).

     In the case that the cropping of the page at the target is unknown, we
     still end up at the wrong position.

  autotests/data/pdf_with_internal_links.pdf | Bin 0 -> 60899 bytes
  autotests/data/pdf_with_internal_links.tex |   9 ++++++
  autotests/parttest.cpp                     |  44 
+++++++++++++++++++++++++++++
  part/pageview.cpp                          |  18 +++++++++---
  4 files changed, 67 insertions(+), 4 deletions(-)
  create mode 100644 autotests/data/pdf_with_internal_links.pdf
  create mode 100644 autotests/data/pdf_with_internal_links.tex


Here is the full log:

git bisect start
# good: [6f5b23290fdd2ada8e0e7f44ffada02c978d0c6a] presentation: Show 
better the status of the "playing" button
git bisect good 6f5b23290fdd2ada8e0e7f44ffada02c978d0c6a
# bad: [4afd21470147dd7b20f21e8edf20e5f350f98df3] 
ToggleActionMenu::createWidget(): Do not crash if parent is not a QToolBar
git bisect bad 4afd21470147dd7b20f21e8edf20e5f350f98df3
# good: [67325270eca8bc5a725a4a0283537b8078d9c1a6] Fix viewport jumps 
when drag-scrolling beyond screen edges
git bisect good 67325270eca8bc5a725a4a0283537b8078d9c1a6
# bad: [b15accd0ae51c68fbd1b1b09a3d12ffcd24a5f55] Checks whether the pdf 
is broken or not
git bisect bad b15accd0ae51c68fbd1b1b09a3d12ffcd24a5f55
# bad: [394001017e9ddfba941fb0fc9162bbfd10c49392] Merge remote-tracking 
branch 'origin/release/21.04'
git bisect bad 394001017e9ddfba941fb0fc9162bbfd10c49392
# good: [6b3da83f69d1d61baf5f056494d4ae809ee41825] Merge remote-tracking 
branch 'origin/release/21.04'
git bisect good 6b3da83f69d1d61baf5f056494d4ae809ee41825
# bad: [61551d2356ea5f93ba3e921a1c4ab9cca88fdbda] Fix: Viewport coords 
normalized w.r.t. full page
git bisect bad 61551d2356ea5f93ba3e921a1c4ab9cca88fdbda
# good: [e8e4cd7c6dc28deead28682a876dd0e2e4ef643d] GIT_SILENT Upgrade 
release service version to 21.04.0.
git bisect good e8e4cd7c6dc28deead28682a876dd0e2e4ef643d
# good: [ff5f4cbc453d37f5c70e7c31a6c22105cee994fc] Open the signed 
document on the page with the new signature
git bisect good ff5f4cbc453d37f5c70e7c31a6c22105cee994fc
# good: [218c5ab64ea2865272a26f18b22c8047226ad957] GIT_SILENT made 
messages (after extraction)
git bisect good 218c5ab64ea2865272a26f18b22c8047226ad957
# first bad commit: [61551d2356ea5f93ba3e921a1c4ab9cca88fdbda] Fix: 
Viewport coords normalized w.r.t. full page


Hope this helps.

Cheers,

Wouter


On 17/09/2021 13:19, David Hurka wrote:
> https://bugs.kde.org/show_bug.cgi?id=442503
>
> David Hurka <david.hurka at mailbox.org> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>               Status|NEEDSINFO                   |REPORTED
>           Resolution|WAITINGFORINFO              |---
>
> --- Comment #10 from David Hurka <david.hurka at mailbox.org> ---
> Thanks. I think I recreated all preconditions correctly, but unfortunately
> still can not reproduce the issue.
>
> I don’t know what else could be relevant.
>
> If you know how to do that, you may build Okular from source and do a git
> bisect to find the problem. The source is located at
> https://invent.kde.org/graphics/okular. The README.md contains a description
> how to build from source. If you are interested, we can help you with that. :)
>

-- 
You are receiving this mail because:
You are the assignee for the bug.