[okular] [Bug 444971] Okular crashed when opening a markdown file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=444971

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/f686f4c6
                   |                            |bf45b92784a6bf90a037199158f
                   |                            |f0073

--- Comment #3 from Albert Astals Cid <aacid at kde.org> ---
Git commit f686f4c6bf45b92784a6bf90a037199158ff0073 by Albert Astals Cid.
Committed on 08/11/2021 at 21:23.
Pushed by aacid into branch 'release/21.12'.

Markdown: Don't crash on files with html images, alt text, inside links

If we have code like <a><img></a><a><img></a> and the img has alt text

The old code did
  remove image
  insert alt text
but when we remove the image, the qtextdocument says
  "i don't need the <a> anymore since there's nothing inside"
and then everything breaks because the layout has changed and we're
iterating over "unexisting" text blocks

So instead we just insert the alt text and
since we have selected the image with the cursor it will
replace it correctly

M  +0    -1    generators/markdown/converter.cpp

https://invent.kde.org/graphics/okular/commit/f686f4c6bf45b92784a6bf90a037199158ff0073

-- 
You are receiving this mail because:
You are the assignee for the bug.