[okular] [Bug 407217] Toggle Change Colors button does not toggle

David Hurka bugzilla_noreply at kde.org
Sun May 30 00:09:01 BST 2021


https://bugs.kde.org/show_bug.cgi?id=407217

David Hurka <david.hurka at mailbox.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/195bbe36
                   |                            |36155613555c27f4e67d21aa146
                   |                            |1a5b6
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from David Hurka <david.hurka at mailbox.org> ---
Git commit 195bbe3636155613555c27f4e67d21aa1461a5b6 by David Hurka.
Committed on 29/05/2021 at 23:08.
Pushed by davidhurka into branch 'master'.

Create color mode menu.

Implemented using a ColorModeMenu class,
derived from ToggleActionMenu (derived from KActionMenu),
as a child object of PageView.

* KToggleAction for every color mode, allows to set shortcuts for every mode.
  Color mode actions have icons.
* KToggleAction for normal colors mode.
* ToggleActionMenu containing all color mode actions.
  If triggered, toggles color mode between normal colors and last change colors
mode.

"Toggle Change Colors" is replaced by "Change Colors", which is actually a
toggle action.
Related: bug 437755

M  +2    -1    CMakeLists.txt
M  +7    -0    conf/okular.kcfg
M  +4    -0    conf/okular_core.kcfg
A  +145  -0    part/colormodemenu.cpp     [License: GPL (v2+)]
A  +74   -0    part/colormodemenu.h     [License: GPL (v2+)]
M  +7    -15   part/pageview.cpp
M  +0    -3    part/pageview.h
M  +19   -2    part/part.cpp
M  +1    -0    part/part.h
M  +8    -1    part/preferencesdialog.cpp
M  +2    -0    part/preferencesdialog.h

https://invent.kde.org/graphics/okular/commit/195bbe3636155613555c27f4e67d21aa1461a5b6

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list