[okular] [Bug 436808] Okular crashes when closing it.

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=436808

Ahmad Samir <a.samirh78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kwidgetsaddons/commi
                   |                            |t/2c4e4bdab18e1d590403c96c8
                   |                            |2efe6ca30b55638
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Ahmad Samir <a.samirh78 at gmail.com> ---
Git commit 2c4e4bdab18e1d590403c96c82efe6ca30b55638 by Ahmad Samir.
Committed on 10/05/2021 at 11:51.
Pushed by dfaure into branch 'master'.

Fix crash in KSelectAction

If the destroyed() signal from QComboBox, which is connected to the
comboBoxDeleted() slot, is emitted while the KSelectAction object is being
taken down, there is a crash is QList::removeAll(). Fix the issue by
disconnecting the signal in the KSelectActionPrivate() destructor.

This fixes a crash when closing a window that contains some KSelectAction
objects (e.g. KMail composer window, and OKular).

Add a comment explaining why the KSelectActionPrivate() destructor is virtual,
the comment is taken from an old commit by pino in kdelibs circa 2007 :)

Add unit test.

M  +32   -0    autotests/kselectaction_unittest.cpp
M  +2    -0    autotests/kselectaction_unittest.h
M  +4    -0    src/kselectaction_p.h
M  +2    -1    tests/kselectactiontest.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/2c4e4bdab18e1d590403c96c82efe6ca30b55638

-- 
You are receiving this mail because:
You are the assignee for the bug.