[okular] [Bug 421822] 'Scroll Page Up'/'Scroll Page Down' actions scroll by scrollbar height instead of viewport height, which is incorrect when scrollbars are disabled

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=421822

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/c399a110
                   |                            |54fffafb86938077a0591c05a4a
                   |                            |3511c
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #31 from Nate Graham <nate at kde.org> ---
Git commit c399a11054fffafb86938077a0591c05a4a3511c by Nate Graham, on behalf
of David Hurka.
Committed on 22/07/2021 at 21:05.
Pushed by ngraham into branch 'release/21.08'.

Fix Page Up/Down scrolling when scrollbars are turned off

PageView::slotScrollUp/Down() queried the size of the scrollbar instead of the
viewport,
which has no obvious reason and doesn’t work when scrollbars are not there.

Probably the scrollbar size was thought to be more robust
in times when PageView had overshoot enabled.

Also fixes code documentation for these methods,
and removes another spaghetti feature where Continuous mode was queried
in an `if` branch before the one where it is relevant.

M  +10   -10   part/pageview.cpp

https://invent.kde.org/graphics/okular/commit/c399a11054fffafb86938077a0591c05a4a3511c

-- 
You are receiving this mail because:
You are the assignee for the bug.