[okular] [Bug 428257] Closing tabs changes focus to sidebar which breaks Ctrl+Tab

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=428257

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/91dbaa1f
                   |                            |5bbff9a50b67b2c165f30f5b4a7
                   |                            |f437a
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Albert Astals Cid <aacid at kde.org> ---
Git commit 91dbaa1f5bbff9a50b67b2c165f30f5b4a7f437a by Albert Astals Cid.
Committed on 27/10/2020 at 22:37.
Pushed by aacid into branch 'master'.

Set focus to the next current tab when closing the current tab

And by that it means giving the focus to the pageview which is most of
the fimes what we want. One could argue that if i had the focus on the
searchbar we should restore the focus there, but that makes not much
sense to me, since each tab is it's own world, at most one could say,
let's remember where the focus was in that tab the last time it was
focused and restore it there, but it seems a bit convoluted.

To be able of setting the focus to the pageview from the shell we need
to set up some focus proxies, so that part->widget (which is the sidebar)
ends up giving the focus to the pageview, which is what makes sense if
someone says "you part, set yourself the focus"

M  +1    -0    part.cpp
M  +12   -0    shell/shell.cpp
M  +1    -0    ui/sidebar.cpp

https://invent.kde.org/graphics/okular/commit/91dbaa1f5bbff9a50b67b2c165f30f5b4a7f437a

-- 
You are receiving this mail because:
You are the assignee for the bug.