[okular] [Bug 421469] [Regression] Slow search in the contents pane

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=421469

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/793f1692
                   |                            |db244621a0a603a2a7c404cc175
                   |                            |7b9ab
             Status|CONFIRMED                   |RESOLVED

--- Comment #10 from Albert Astals Cid <aacid at kde.org> ---
Git commit 793f1692db244621a0a603a2a7c404cc1757b9ab by Albert Astals Cid, on
behalf of Ahmad Samir.
Committed on 23/05/2020 at 10:11.
Pushed by aacid into branch 'release/20.04'.

Fix filtering items in the contents treeview

When filtering the items in the contents panel, we start iterating over
them using rootIndex() to get all the children, don't do the same loop
for each and every item, one go is enough.

Also only use a regular expression if the regularExpression option is
enabled, otherwise just use string operations, the latter is always
faster. With this change, both regex and non-regex search are faster.

M  +13   -12   ui/ktreeviewsearchline.cpp

https://invent.kde.org/graphics/okular/commit/793f1692db244621a0a603a2a7c404cc1757b9ab

-- 
You are receiving this mail because:
You are the assignee for the bug.