[okular] [Bug 421469] [Regression] Slow search in the contents pane

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=421469

--- Comment #7 from Ahmad Samir <a.samirh78 at gmail.com> ---
Indeed it is slower... reverting the changes in
KTreeViewSearchLine::itemMatches() restores the old behaviour. I am looking at
it, so far I don't see anything obvious, other than that QRegExp::FixedString
has some kind of optimisation that is much faster than what can be achieved by
using QRegularExpression::escape() on the pattern (QRegExp docs say that using
FixedString is equivalent to searching by using a pattern escaped by using
QRegExp::escape()).

I could just use plain string comparison when the "regular expression" search
option is disabled; string comparison is always faster than regular expression;
that doesn't fix the issue for "regular expression"... I'll test some more (but
it'll have to wait until tomorrow, it's getting late and I am almost
asleep...).

Sorry about the trouble :)

-- 
You are receiving this mail because:
You are the assignee for the bug.