[okular] [Bug 418520] Find function misses occurrences of target string that wrap from one line to next line of document text.

[avlas]

https://bugs.kde.org/show_bug.cgi?id=418520

--- Comment #6 from avlas <jsardid at gmail.com> ---
(In reply to avlas from comment #4)
> (In reply to Albert Astals Cid from comment #2)
> > Git commit 9694113a961cb5a5d6ef18ce0beeaa975a8c6db3 by Albert Astals Cid.
> > Committed on 28/03/2020 at 13:59.
> > Pushed by aacid into branch 'master'.
> > 
> > Let the user type the hyphen if he wants when searching
> > 
> > It happens that sometimes the hypen is actually "part of the word" like
> > in one-third, so if there's one- at the end of a line
> > and third at the beginning of the next, we should still match and not
> > force the user to type onethird, even we will also match onethird since
> > there's no way to know if "hyphen at end of line" is supposed to be part
> > of the word or not
> > 
> > M  +16   -0    autotests/searchtest.cpp
> > M  +129  -114  core/textpage.cpp
> > 
> > https://invent.kde.org/kde/okular/commit/
> > 9694113a961cb5a5d6ef18ce0beeaa975a8c6db3
> 
> This contribution is excellent, thanks!
> 
> However, justified text which is the case in most papers/articles/etc most
> frequently introduce hyphenation, I think having few false positives (if
> this change would apply to hyphens) justifies the expected high number false
> negatives when ommitting hyphens: it's just much more likely that a word is
> "di-vided" (and all of them would still be ommitted) than searching for two
> independent hyphenated words, such as one-third.
> 
> Not asking to make it default, but based on that, could you please give that
> option so users are able to omit endline hyphens? That would help some of us
> greatly

To be more specific, under that option:

- typing divided would find divided, di- \n vided, divid- \n ed, etc
- typing one-third would find one-third and one- \n third
- typing onethird would find onethird and one- \n third

-- 
You are receiving this mail because:
You are the assignee for the bug.