[okular] [Bug 421508] Cannot type anything in some form fields

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=421508

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/d78cbb79
                   |                            |c98e01fc524ec91fb099ec8ff98
                   |                            |cc1fa
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Albert Astals Cid <aacid at kde.org> ---
Git commit d78cbb79c98e01fc524ec91fb099ec8ff98cc1fa by Albert Astals Cid.
Committed on 15/06/2020 at 20:45.
Pushed by aacid into branch 'release/20.04'.

Fix/Workaround file where we can't enter values in some fields

The problem was that the JS checker for the field format was using the
willCommit property of event and we don't define it so the JS
interpreter was going "ok nope, out of here" and the field didn't get edited.

I've read the willCommit definition in js_api_reference.pdf for almost
30 minutes, and even it's just 3 lines i don't think i understand it,
but i think that returning true is "safer", i.e. says that this event is
going to actually change the field, which as far as i can see it's what
we always do

M  +8    -0    core/script/kjs_event.cpp

https://invent.kde.org/graphics/okular/commit/d78cbb79c98e01fc524ec91fb099ec8ff98cc1fa

-- 
You are receiving this mail because:
You are the assignee for the bug.