What's your feeling in adding a _clang_format file to the repo

Albert Astals Cid aacid at kde.org
Thu Jul 2 21:41:35 BST 2020


El dijous, 4 de juny de 2020, a les 22:58:38 CEST, Albert Astals Cid va escriure:
> This way we would have a common style in the files, which at some point we had, but given how much people have been commiting and how not annoying i've been with style in reviews we don't have anymore.
> 
> Attached my suggestion.
> 
> Problem is that it changes basically everything
>  470 files changed, 54659 insertions(+), 62376 deletions(-)
> 
> So one would need to always use a --ignore-revs when doing git blame for it to be useful.
> 
> Opinions?

"Voting time" over.

Results:
 2 yes
 1 "don't really care".

I'll propose a merge request for master after 20.04.3 is released (that way we don't have to worry about merges from stable being painful because of the reformatting).

Cheers,
  Albert

> 
> Albert






More information about the Okular-devel mailing list