D15580: New annotation toolbar
Albert Astals Cid
noreply at phabricator.kde.org
Tue Feb 4 18:37:12 GMT 2020
aacid added a comment.
In D15580#605913 <https://phabricator.kde.org/D15580#605913>, @davidhurka wrote:
> In D15580#605611 <https://phabricator.kde.org/D15580#605611>, @simgunz wrote:
>
> > aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.
>
>
> It’s okay to me that you write the autotests. If you wish, I could do that instead.
>
> I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?
The functionality in Okular, so that if in the future we replace ToggleActionMenu with EvenBetterToggleActionMenu we can spot regressions
REPOSITORY
R223 Okular
BRANCH
new-annotation-toolbar_ToggleActionMenu
REVISION DETAIL
https://phabricator.kde.org/D15580
To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, gennad, fbampaloukas, joaonetto, kezik, tfella, skadinna, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20200204/0354a9c3/attachment-0001.html>
More information about the Okular-devel
mailing list