D21971: Replace ToolAction by ToggleActionMenu

[Albert Astals Cid]

aacid added a comment.


  I'm going to merge this because it's been hanging around for more than 6 months and Simone is vouching for it, but honestly for stuff like this we should have UI autotests since it's the thing that will *defenitely* break in the future because it does so many things people will not even be sure what was the intended behaviour.
  
  My suggestion before you go and continue trying to get D15580 <https://phabricator.kde.org/D15580> landed is get some autotests on the ToggleActionMenu functionality.
  
  Also i would really appreciate if you could change to using invent.kde.org instead of phabricator, this way we have the automated code checking tools running on your code patch.

REPOSITORY
  R223 Okular

BRANCH
  create-configurable-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka, simgunz
Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20200202/1be3be2f/attachment.html>