D10455: Add RTL support for search, copy & paste in pdf

[David Hurka]

davidhurka added a comment.


  I read the reported test results as if this doesn’t work correctly. However, without this patch it doesn’t work at all, so that may already be an argument to accept this patch.
  
  Text handling and search is IMHO broken in general, and needs to be redone. The current approach reorders all TextEntities, to give a nice left-to-right-top-to-bottom order. That is nice in general, but I think it should be done only on paragraph level, not on character level.
  
  What needs to happen next for this patch, is probably to rebase it on master, and submit it on invent.kde.org. Then we can see together how to fix the mentioned memory leaks.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: davidhurka, yaron, okular-devel, chfanzil, ngraham, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20201228/1977bb5e/attachment.htm>