[okular] [Bug 424810] Assert crash when selecting quick annotation tool that was added in the config dialog

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=424810

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/72f5a2db
                   |                            |089178c1e9eca82ba5a9a97fff2
                   |                            |a49dc
   Version Fixed In|                            |1.11.0

--- Comment #6 from Albert Astals Cid <aacid at kde.org> ---
Git commit 72f5a2db089178c1e9eca82ba5a9a97fff2a49dc by Albert Astals Cid, on
behalf of Simone Gaiarin.
Committed on 05/08/2020 at 22:49.
Pushed by aacid into branch 'release/20.08'.

Find built-in tool corresponding to quick tool at runtime

In this way it is possible to drop the `sourceId` attribute from the quick
tools definition. This simplifies the code logic and makes it easier to update
user settings from the previous version of Okular (because there is no need to
add the attribute `sourceId`

This also fixes the crash due to the fact that `sourceId` was not correctly
created when a quick annotation is created from the Annotation page of Okualr
Settings.
FIXED-IN: 1.11.0

M  +1    -1    autotests/CMakeLists.txt
M  +19   -2    autotests/annotationtoolbartest.cpp
M  +30   -5    ui/annotationactionhandler.cpp
M  +5    -0    ui/data/tools.xml
M  +12   -6    ui/data/toolsQuick.xml
M  +17   -3    ui/pageviewannotator.cpp

https://invent.kde.org/graphics/okular/commit/72f5a2db089178c1e9eca82ba5a9a97fff2a49dc

-- 
You are receiving this mail because:
You are the assignee for the bug.