D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> part.cpp:526
>      connect( m_pageView.data(), &PageView::rightClick, this, &Part::slotShowMenu );
> +    connect( m_pageView, &PageView::triggerSearch, this, &Part::slotShowFindBarWithInitialText );
>      connect( m_document, &Document::error, this, &Part::errorMessage );

You could probably use a lambda here too, to avoid creating a single-use function

> part.cpp:2250
>  
> +void Part::slotShowFindBarWithInitialText(const QString &serchText)
> +{

ditto

> part.h:227
>          void slotShowFindBar();
> +        void slotShowFindBarWithInitialText(const QString& serchText);
>          void slotHideFindBar();

Typo: `serchText` -> `searchText`

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190905/6d49b059/attachment.html>